Manticore: MrlComm will not compile No wurky put in on get hub

It used to compile not anymore have fresh copy of Manticore  tried raspi, win10 and win7 same error on all. see below.

Arduino: 1.8.11 (Windows 7), Board: "Arduino Mega or Mega 2560, ATmega2560 (Mega 2560)"
 
In file included from sketch\LinkedList.h:72:0,
 
                 from sketch\MrlComm.cpp:10:
 
sketch\LinkedList.cpp: In instantiation of 'LinkedList<T>::~LinkedList() [with T = Device*]':
 
sketch\MrlComm.cpp:29:18:   required from here
 
sketch\LinkedList.cpp:21:13: warning: ISO C++ forbids comparison between pointer and integer [-fpermissive]
 
   while(root!=false) {
 
         ~~~~^~~~~~~
 
sketch\LinkedList.cpp: In instantiation of 'LinkedList<T>::~LinkedList() [with T = Pin*]':
 
sketch\MrlComm.cpp:29:18:   required from here
 
sketch\LinkedList.cpp:21:13: warning: ISO C++ forbids comparison between pointer and integer [-fpermissive]
 
sketch\LinkedList.cpp: In instantiation of 'ListNode<T>* LinkedList<T>::getNode(int) [with T = Device*]':
 
sketch\LinkedList.cpp:182:29:   required from 'T LinkedList<T>::get(int) [with T = Device*]'
 
sketch\MrlComm.cpp:228:38:   required from here
 
LinkedList.cpp:53:10: error: cannot convert 'bool' to 'ListNode<Device*>*' in return
 
   return false;
 
          ^~~~~
 
sketch\LinkedList.cpp: In instantiation of 'ListNode<T>* LinkedList<T>::getNode(int) [with T = Pin*]':
 
sketch\LinkedList.cpp:170:29:   required from 'T LinkedList<T>::remove(int) [with T = Pin*]'
 
sketch\MrlComm.cpp:297:24:   required from here
 
LinkedList.cpp:53:10: error: cannot convert 'bool' to 'ListNode<Pin*>*' in return
 
exit status 1
cannot convert 'bool' to 'ListNode<Device*>*' in return
 
This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.
 
 
Thanks I know you have a lot going

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
GroG's picture

This should work  Change

This should work 
Change Line 53 from :

return false;

to 

return NULL;

if you want to get rid of the warning too on line 21

you'd change

 while(root!=false)

to

 while(root!=NULL)

kg5kzh's picture

Thanks GroG

Will give it a try in a bit

kg5kzh's picture

Thanks GroG no other compile errors

Awesome